Skip to content

GNUmakefile: debug build uudoc for faster build and CI #10496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oech3 wants to merge 1 commit into from
Closed

GNUmakefile: debug build uudoc for faster build and CI #10496

oech3 wants to merge 1 commit into from

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 26, 2026

Workaround for #10492 .

@oech3 oech3 marked this pull request as ready for review January 26, 2026 18:30
@github-actions
Copy link

github-actions bot commented Jan 26, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/date/date-ethiopia is no longer failing!
Congrats! The gnu test tests/date/date-iran is no longer failing!
Congrats! The gnu test tests/date/date-thailand is no longer failing!

@oech3 oech3 changed the title GNUmakefile: debug build uudoc for faster install GNUmakefile: debug build uudoc for faster build and CI Jan 26, 2026
@aaron-ang
Copy link
Contributor

aaron-ang commented Jan 27, 2026

we may want to keep symbols and debug info for CI, and remove them for the default path (public use)

@oech3
Copy link
Contributor Author

oech3 commented Jan 27, 2026 via email

@aaron-ang
Copy link
Contributor

aaron-ang commented Jan 27, 2026 •
edited
Loading

Does CI use GNU make for tests for uudoc?

CI uses make here to check makefile

coreutils/.github/workflows/CICD.yml

Line 303 in adf36f9

env CARGO_BUILD_TARGET=aarch64-unknown-linux-gnu make install-manpages PREFIX=/tmp/usr UTILS=true

but builds its targets (including uudoc) using cargo in release mode

coreutils/.github/workflows/CICD.yml

Line 633 in adf36f9

- { os: ubuntu-latest , target: x86_64-unknown-linux-gnu , features: "feat_os_unix,uudoc" , use-cross: no, workspace-tests: true }

coreutils/.github/workflows/CICD.yml

Lines 849 to 851 in adf36f9

## Build
${{ steps.vars.outputs.CARGO_CMD }} ${{ steps.vars.outputs.CARGO_CMD_OPTIONS }} build --release --config=profile.release.strip=true \
--target=${{ matrix.job.target }} ${{ matrix.job.cargo-options }} ${{ steps.vars.outputs.CARGO_FEATURES_OPTION }} ${{ steps.vars.outputs.CARGO_DEFAULT_FEATURES_OPTION }}

and expects uudoc to be in release dir

coreutils/.github/workflows/CICD.yml

Lines 886 to 896 in adf36f9

- name: Package manpages and completions
if: matrix.job.target == 'x86_64-unknown-linux-gnu' && matrix.job.features == 'feat_os_unix,uudoc'
run: |
mkdir -p share/{man/man1,bash-completion/completions,fish/vendor_completions.d,zsh/site-functions,elvish/lib}
_uudoc=target/${{ matrix.job.target }}/release/uudoc
for bin in $('target/${{ matrix.job.target }}/release/coreutils' --list) coreutils;do
${_uudoc} manpage ${bin} > share/man/man1/${bin}.1
${_uudoc} completion ${bin} bash > share/bash-completion/completions/${bin}.bash
${_uudoc} completion ${bin} fish > share/fish/vendor_completions.d/${bin}.fish
${_uudoc} completion ${bin} zsh > share/zsh/site-functions/_${bin}
${_uudoc} completion ${bin} elvish > share/elvish/lib/${bin}.elv

You might need to amend these areas to port uudoc to dev build.

@oech3
Copy link
Contributor Author

oech3 commented Jan 27, 2026

I think we can override definition of uudoc's release profile only at *.toml. No?

@aaron-ang
Copy link
Contributor

aaron-ang commented Jan 27, 2026

the CI script clearly adds the --release flag, im not sure if the toml config overwrites that.

@oech3 oech3 closed this Jan 27, 2026
@oech3 oech3 deleted the patch-12 branch January 27, 2026 18:15
@sylvestre
Copy link
Contributor

sylvestre commented Jan 27, 2026

@oech3 sorry, you don't have to close existing PR :)
i was just talking about future PR

@oech3
Copy link
Contributor Author

oech3 commented Jan 27, 2026

This PR is low quality and potentially replaced by better solution.

@sylvestre
Copy link
Contributor

sylvestre commented Jan 27, 2026

ok, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oech3 @aaron-ang @sylvestre